Skip to content

Audit Feedback#35

Open
cristovaoth wants to merge 2 commits intomasterfrom
audit-feedback
Open

Audit Feedback#35
cristovaoth wants to merge 2 commits intomasterfrom
audit-feedback

Conversation

@cristovaoth
Copy link
Collaborator

This PR contains addresses the following points raised during audit:

  • Replace IGuard with IModuleGuard interface
  • ZeroHash return on invalid ecrecover signature for consistency with ERC1271 path

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants