Skip to content

Commit

Permalink
deps: Use a patched rn-fetch-blob to fix Android 14+ crash
Browse files Browse the repository at this point in the history
This updates rn-fetch-blob to a version with one cherry-picked commit
atop the v0.11.2 we were previously using:
  zulip/rn-fetch-blob@e17b2a51c

The rn-fetch-blob package itself is no longer maintained:
  joltup/rn-fetch-blob#863

There's a fork that is maintained, `react-native-blob-util`:
  https://npmjs.com/package/react-native-blob-util

That fork addressed the Android 14 requirement to set an
explicit RECEIVER_EXPORTED flag (zulip#5903), merging a fix:
  RonRadtke/react-native-blob-util#303
  RonRadtke/react-native-blob-util#306

Our fix is cherry-picked from that one.

(If this app weren't a legacy codebase in maintenance mode, we'd take
the time to upgrade this dependency more generally, probably switching
to the react-native-blob-util fork.  As is, we'll skip that and use
the time to focus on completing the new Flutter app.)

Fixes: zulip#5903
  • Loading branch information
gnprice committed Nov 5, 2024
1 parent fc23edd commit 29797ca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"redux-logger": "^3.0.1",
"redux-thunk": "^2.1.0",
"reselect": "^4.0.0",
"rn-fetch-blob": "^0.11.0",
"rn-fetch-blob": "zulip/rn-fetch-blob#e17b2a51c",
"timezone": "^1.0.13",
"zulip-markdown-parser": "^1.0.6"
},
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11349,10 +11349,9 @@ rimraf@~2.4.0:
dependencies:
glob "^6.0.1"

rn-fetch-blob@^0.11.0:
rn-fetch-blob@zulip/rn-fetch-blob#e17b2a51c:
version "0.11.2"
resolved "https://registry.yarnpkg.com/rn-fetch-blob/-/rn-fetch-blob-0.11.2.tgz#bdc483bf1b0c3810d457983494a11fbada446679"
integrity sha512-oKszdNtA7vZ56d0Rfr+RDEUexwlZxu/HOqwULa36PRHhQsTO5ia7uKk+va3WzuwYxzhF9e0bY8n3k+GC6Df14A==
resolved "https://codeload.github.com/zulip/rn-fetch-blob/tar.gz/e17b2a51ce4480ccac07f11ef1f28d76061af592"
dependencies:
base-64 "0.1.0"
glob "7.0.6"
Expand Down

0 comments on commit 29797ca

Please sign in to comment.