Fix default assignment and constructor for non trivial types #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storage for non trivial type would still generate default copy/move constructors. Vector class would then generate default ones even in case explicitly defined constructors were not allowed via type traits. Default constructor is preferred over templated constructor. Deleting non trivial storage constructors prevents them from being generated for vector class and forcing compiler to pick available template constructors secured with type traits. Also, move assignment operator should depend on move-constructability, otherwise it would not be instantiated for non-copyable types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage for non trivial type would still generate default copy/move constructors. Vector class would then generate default ones even in case explicitly defined constructors were not allowed via type traits. Default constructor is preferred over templated constructor. Deleting non trivial storage constructors prevents them from being generated for vector class and forcing compiler to pick available template constructors secured with type traits.
Also, move assignment operator should depend on move-constructability, otherwise it would not be instantiated for non-copyable types.