go.mod: require go-delve/liner instead of peterh/liner #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of `replace` in go.mod breaks delve installation using `go install`. (see golang/go#40276) Workaround this limitation by explicitly require the fork github.com/go-delve/liner. go-delve/[email protected] already has go.mod module name fixed to be github.com/go-delve/liner. Fixes go-delve#2904
aarzilli
approved these changes
Feb 13, 2022
|
cc @derekparker |
|
Is vscode-go still installing |
|
Not any more, but some systems depending on github/vscode dev containers still install dlv from master. Fixes in github&vscode were committed, but not released. So some users in downstream are stuck. :-( |
|
Merged for charitable reasons, Derek can always revert. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
replacein go.mod breaks delve installation usinggo install. (see golang/go#40276)Workaround this limitation by explicitly require the fork
github.com/go-delve/liner.
go-delve/[email protected] already has go.mod module name fixed
to be github.com/go-delve/liner. go-delve/[email protected] also
has complete go.mod that made github.com/mattn/go-runewidth
declared as an implicit dependency and get pulled into the vendor
directory correctly.
Fixes #2904