feat: badge support tag #32451
feat: badge support tag #32451
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
|
Maybe |
|
Do you mean I need to support |
Or |
pull-request-size
bot
added
size/M
|
Done. |
| var ref string | ||
| switch { | ||
| case useLatestTag: | ||
| tags, _, err := ctx.Repo.GitRepo.GetTagInfos(0, 1) |
There was a problem hiding this comment.
I think you should use a function like GetLatestReleaseByRepoID to do that.
There was a problem hiding this comment.
So we need the tag of the latest release here? Do we need to rename it to latest_release_tag?
There was a problem hiding this comment.
No. All tags have been synced into databases. They shared the same table with releases.
| if len(tags) != 0 { | ||
| tag = tags[0].Name | ||
| } else { | ||
| tag = "" // return empty result on no tag |
There was a problem hiding this comment.
If it's empty, we should return error.
| ref = fmt.Sprintf("refs/tags/%s", tag) | ||
| case branch != "": | ||
| ref = fmt.Sprintf("refs/heads/%s", branch) | ||
| default: | ||
| branch = ctx.Repo.Repository.DefaultBranch |
There was a problem hiding this comment.
This assign statement is unnecessary.
There was a problem hiding this comment.
Should I
if useLatestTag {
tag = "xxx"
}
switch {
// ...
}
or add a fallthrough?
Add a
tagparameter to the badge.svg endpoint. Whenbranchis empty, it will usetagto search for the workflow run. This is useful for badges for release.e.g. https://example.com/org/repo/actions/workflows/release.yaml/badge.svg?tag=h4&event=release