Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix container push #33214

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Fix container push #33214

wants to merge 1 commit into from

Conversation

wxiaoguang
Copy link
Contributor

Fix #26839, fix #25893

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 11, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 11, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 11, 2025 •
edited
Loading

@KN4CK3R I managed to figure out the root problem of #26839 and #25893

This "quick fix" makes the push could succeed, but I think it is not good enough (actually not quite right)

Would you like to take a look and improve the fix?

@wxiaoguang wxiaoguang requested a review from KN4CK3R January 11, 2025 07:33
@wxiaoguang wxiaoguang marked this pull request as draft January 11, 2025 07:33
@wxiaoguang wxiaoguang changed the title Fix container push WIP: Fix container push Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@wxiaoguang @GiteaBot