Rework delete org and rename org UI #34762
Draft
+177
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/enhancement
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
hiifong
approved these changes
Jun 19, 2025
GiteaBot
added
lgtm/need 1
yp05327
approved these changes
Jun 20, 2025
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Jun 20, 2025
options/locale/locale_en-US.ini
Outdated
|
|
||
| settings.rename = Rename Organization | ||
| settings.rename_desc = Changing the organization name will also change your organization's URL and free the old name. | ||
| settings.rename_success = Organization %s have been renamed to %s successfully. |
wxiaoguang
reviewed
Jun 20, 2025
|
|
||
| // SettingsRename response for renaming organization | ||
| func SettingsRename(ctx *context.Context) { | ||
| form := web.GetForm(ctx).(*forms.RenameOrgForm) |
There was a problem hiding this comment.
Just curious why introduce a new "RenameOrgForm" struct.
Are the errors properly processed if the form validation fails?
Or it should be as simple as read the values by FormString?
There was a problem hiding this comment.
To reuse the binding middleware which can validate the length and the username like previous routers. If we use FormString, we have to do the validation manually. This is what the error looks like.
wxiaoguang
reviewed
Jun 20, 2025
templates/org/settings/options.tmpl
Outdated
| </div> | ||
| <div class="required field"> | ||
| <label for="org_name_to_delete">{{ctx.Locale.Tr "org.org_name_holder"}}</label> | ||
| <input id="org_name_to_delete" name="org_name" required> |
There was a problem hiding this comment.
We already have a framework-level support.
So please do not write these IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem of the original implementation
Renaming organization will mix with organization's information change make the operation difficult to keep consistent.
This PR created a danger zone like what's repository setting. It also moved organization's
renameanddeleteoperations to this zone. The original updating repository will not change the name any more.This is also a step to extract the
updaterepositoryfunction completely.Before:
After: