Improve code review comments #35077
Draft
Improve code review comments #35077
+1,009
−686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
lunny
force-pushed
the
lunny/code_review_line_number
branch
from
ff37d02 to
fd82a60
Compare
…nch has a force-push
lunny
force-pushed
the
lunny/code_review_line_number
branch
from
fd82a60 to
791339a
Compare
lunny
commented
Jul 16, 2025
| @@ -730,28 +730,23 @@ func prepareIssueViewCommentsAndSidebarParticipants(ctx *context.Context, issue | |||
| } | |||
| comment.Review.Reviewer = user_model.NewGhostUser() | |||
| } | |||
| if err = comment.Review.LoadCodeComments(ctx); err != nil { | |||
There was a problem hiding this comment.
duplicated with LoadAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30844
Fix #29715
Fix #21113
Fix #31551