Skip to content

Remove incorrect "db.DefaultContext" usages #35366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 28, 2025
Merged

Remove incorrect "db.DefaultContext" usages #35366

merged 6 commits into from
Aug 28, 2025

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 27, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Aug 27, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/migrations labels Aug 27, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 27, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 27, 2025
@a1012112796

This comment was marked as off-topic.

Sign in to view
@wxiaoguang
Copy link
Contributor Author

can this be checked by lint tools?

There will be no "db.DefaultContext" anymore

@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Aug 28, 2025
@wxiaoguang
Copy link
Contributor Author

can this be checked by lint tools?

There will be no "db.DefaultContext" anymore

I was planning to use 2 PRs to remove the "db.DefaultContext". Now all-in-one

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 28, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) August 28, 2025 03:43
@wxiaoguang wxiaoguang merged commit 0cbaa0b into go-gitea:main Aug 28, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-db-ctx branch August 28, 2025 04:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 28, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
553f2da 
* giteaofficial/main:
  Remove incorrect "db.DefaultContext" usages (go-gitea#35366)
  Refactor to use reflect.TypeFor (go-gitea#35370)
  [skip ci] Updated translations via Crowdin
  Remove wrong "git.DefaultContext" (go-gitea#35364)
  Fix context usages (go-gitea#35348)
  Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357)
  Allow deleting comment with content via API like web did (go-gitea#35346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/migrations skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @a1012112796 @lunny @GiteaBot