Use gitrepo.Repository instead of wikipath #35398
Conversation
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
…nto lunny/remove_wiki_path_ref
lunny
changed the title
…nto lunny/remove_wiki_path_ref
…nto lunny/remove_wiki_path_ref
GiteaBot
added
lgtm/need 1
|
It seems that the tests are removed, but there's no new one added? |
The method |
GiteaBot
added
lgtm/done
modules/gitrepo/clone.go
Outdated
| func CloneIn(ctx context.Context, dstRepo Repository, from string, opts git.CloneRepoOptions) error { | ||
| return git.Clone(ctx, from, repoPath(dstRepo), opts) | ||
| } | ||
|
|
||
| func CloneOut(ctx context.Context, fromRepo Repository, to string, opts git.CloneRepoOptions) error { | ||
| return git.Clone(ctx, repoPath(fromRepo), to, opts) | ||
| } |
There was a problem hiding this comment.
CloneRepoToLocal
CloneLocalToRepo, but I don't understand why it is needed, why a git repo should be cloned from local to the managed repo directory.
There was a problem hiding this comment.
CloneIn means clone an external repository into the managed repository. like migration from github or other system. CloneOut means CloneRepoToLocal
There was a problem hiding this comment.
But why you flip the argument order?
git clone from to, git.Clone(from, to), why here you sometimes use to, from, sometimes use from, to order?
Can there be some consistence?
5 participants
Now the wikipath will not be referenced directly.