Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 2, 2025

Related to #32018

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 2, 2025
@lunny lunny marked this pull request as ready for review September 5, 2025 23:05
@silverwind
Copy link
Member

silverwind commented Sep 10, 2025

I guess this may be an acceptable workaround but I ultimately I think it's a bug in git if it leaves stale lockfiles around (assuming we only use git commands to add those remotes).

@lunny
Copy link
Member Author

lunny commented Sep 11, 2025

I guess this may be an acceptable workaround but I ultimately I think it's a bug in git if it leaves stale lockfiles around (assuming we only use git commands to add those remotes).

It’s not a Git bug. The Git subprocess may exit abnormally or be canceled if Gitea shuts down, reboots, or exits unexpectedly.

@silverwind
Copy link
Member

Ok, and git does not offer any commands to clean up lockfiles, right? It has to be done with manual deletion?

Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can try it I guess

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2025
@wxiaoguang
Copy link
Contributor

Not right. You can't hard-code these lock file names.

@lunny
Copy link
Member Author

lunny commented Sep 17, 2025

Not right. You can't hard-code these lock file names.

Why not? The lock files in a Git repository are stored at fixed relative locations. Traversing the entire repository just to find them would be inefficient.

@wxiaoguang
Copy link
Contributor

If you have read other Gitea issues like

image

Or have asked AI:

image

And you have been told!!! Would you really learn from lessons?

image

@lunny lunny marked this pull request as draft September 17, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants