Skip to content

Honor delete branch on merge repo setting when using merge API #35488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Honor delete branch on merge repo setting when using merge API #35488

wants to merge 2 commits into from
+10 −1

Conversation

kemzeb
Copy link
Member

@kemzeb kemzeb commented Sep 14, 2025

Fix #35463.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 14, 2025
@kemzeb
Copy link
Member Author

kemzeb commented Sep 14, 2025 •
edited
Loading

The logic has been implemented, but for tests I need to figure out how to work with the git database in the test environment.

Did not see issues when manual-testing the following:

  • Merge with delete branch when merge repo setting is set
  • Merge with delete branch when merge API form field is set
  • Merge without either fields set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging a PR via the API does not honor the Delete pull request branch after merge by default setting
2 participants
@kemzeb @GiteaBot