Remove the licenses.txt build #35515
Open
+5
−1,647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
This was referenced Sep 19, 2025
|
maybe the licenses.txt can be moved to |
No, it has to update every time dependencies change, and they change far too often. The only alternative I consider is moving the generation completely to build-time, likely using a better tool than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generation complicates go dependency updates and inhibts the use of tools like dependabot or renovate which (as far as I'm aware) can not run post-upgrade steps. Also,
google/go-licenseshas bugs which make it exit with errors, I think it's a bad fit.