-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add inline diff in repos/pulls/files api #35620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add the inline diff on a per file basis to be compatible with GitHub Example: ``` curl http://localhost:3000/api/v1/repos/cedstrom/test/pulls/1/files?token=[redacted] ``` ``` [ { "filename": ".gitignore", "status": "added", "additions": 2, "deletions": 0, "changes": 2, "html_url": "http://localhost:3000/cedstrom/test/src/commit/ce2c53223388eaaa026c25156b807e30acc05a56/.gitignore", "contents_url": "http://localhost:3000/api/v1/repos/cedstrom/test/contents/.gitignore?ref=ce2c53223388eaaa026c25156b807e30acc05a56", "raw_url": "http://localhost:3000/cedstrom/test/raw/commit/ce2c53223388eaaa026c25156b807e30acc05a56/.gitignore", "patch": "diff --git a/.gitignore b/.gitignore\n--- a/.gitignore\n+++ b/.gitignore\n@@ -0,1 +1,2 @@\n @@ -0,0 +1,2 @@\n++.env\n++.env.local\n\n" }, { "filename": "README.md", "status": "changed", "additions": 1, "deletions": 0, "changes": 1, "html_url": "http://localhost:3000/cedstrom/test/src/commit/ce2c53223388eaaa026c25156b807e30acc05a56/README.md", "contents_url": "http://localhost:3000/api/v1/repos/cedstrom/test/contents/README.md?ref=ce2c53223388eaaa026c25156b807e30acc05a56", "raw_url": "http://localhost:3000/cedstrom/test/raw/commit/ce2c53223388eaaa026c25156b807e30acc05a56/README.md", "patch": "diff --git a/README.md b/README.md\n--- a/README.md\n+++ b/README.md\n@@ -1,2 +1,3 @@\n @@ -1,2 +1,3 @@\n # test\n \n++This is my first PR.\n\n" } ] ```
For context, I want to use https://github.com/ray5273/ollama-pr-review-action in Gitea, but it depends on this API. |
But the patch maybe very big. Is that necessary to always have that field? |
GitHub does so by default https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests-files |
Could you add a test to confirm the generated patch content is available? |
Done @lunny |
I mean, run the git apply command to verify that the patch content is valid from Git’s perspective since it's not generated by git itself. |
Add the inline diff on a per file basis to be compatible with GitHub
Example: