Skip to content

Fix bugs when comparing and creating pull request #36144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lunny wants to merge 2 commits into
base: release/v1.25
Choose a base branch
from
Open

Fix bugs when comparing and creating pull request #36144

lunny wants to merge 2 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 12, 2025

Backport #36105

@GiteaBot GiteaBot added this to the 1.25.3 milestone Dec 12, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 12, 2025
@lunny lunny changed the title Fix bugs when creating pull request Fix bugs when comparing and creating pull request Dec 12, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2025
@lunny
Copy link
Member Author

lunny commented Dec 12, 2025

Please review #36105 first. :)

@silverwind silverwind self-requested a review December 12, 2025 23:48
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 12, 2025
@silverwind
Copy link
Member

silverwind commented Dec 12, 2025

Sorry, thought it was already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lafriks lafriks lafriks approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/translation

Projects

None yet

Milestone

1.25.3

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @silverwind @lafriks @GiteaBot