Skip to content

Migrate reactions when migrating repository from github #9599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 15, 2020
Merged

Migrate reactions when migrating repository from github #9599

merged 9 commits into from
Jan 15, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 4, 2020 •
edited
Loading

  • Template change, don't think migrator is the reaction author.
  • Unit tests
  • Update original author id when user connected external user account.

An issue migrated from go-gitea/test_repo#2 as below:

图片

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 4, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 10, 2020
@lunny lunny force-pushed the lunny/migrate_reactions branch 2 times, most recently from 255b4e5 to d35b8cb Compare January 10, 2020 13:06
@lunny
Copy link
Member Author

lunny commented Jan 10, 2020 •
edited
Loading

blocked by #9693

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2020
@lunny lunny changed the title WIP: Migrate reactions when migrating repository from github Migrate reactions when migrating repository from github Jan 10, 2020
guillep2k
guillep2k reviewed Jan 10, 2020
View reviewed changes
@lunny lunny force-pushed the lunny/migrate_reactions branch from d35b8cb to 9205730 Compare January 10, 2020 15:53
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2020
@lunny lunny force-pushed the lunny/migrate_reactions branch 4 times, most recently from f8c1e97 to e6997ed Compare January 14, 2020 02:57
@6543
Copy link
Member

6543 commented Jan 14, 2020 

Migration[122]: Add original informations for reactions
--
364 | migration_test.go:225:
365 | Error Trace:	migration_test.go:225
366 | migration_test.go:244
367 | Error:      	Received unexpected error:
368 | migrate: do migrate: Cannot add a NOT NULL column with default value NULL
369 | Test:       	TestMigrations/Migrate-sqlite3-1.7.0

@lunny lunny force-pushed the lunny/migrate_reactions branch from e6997ed to 33495ce Compare January 15, 2020 10:56
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4e566df). Click here to learn what that means.
The diff coverage is 32.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9599   +/-   ##
=========================================
  Coverage          ?   42.16%           
=========================================
  Files             ?      603           
  Lines             ?    78834           
  Branches          ?        0           
=========================================
  Hits              ?    33243           
  Misses            ?    41520           
  Partials          ?     4071
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø)
modules/migrations/base/pullrequest.go 0% <ø> (ø)
models/user.go 50.46% <0%> (ø)
models/issue.go 54.81% <0%> (ø)
routers/repo/issue.go 38.01% <0%> (ø)
models/migrate.go 0% <0%> (ø)
models/migrations/v123.go 0% <0%> (ø)
modules/migrations/gitea.go 6.89% <0%> (ø)
models/external_login_user.go 21.29% <0%> (ø)
routers/api/v1/repo/issue_reaction.go 75.27% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e566df...33495ce. Read the comment docs.

@sapk sapk merged commit 2b3e931 into go-gitea:master Jan 15, 2020
@sapk
Copy link
Member

sapk commented Jan 15, 2020

Oh sorry @6543, I didn't see your comment.

@sapk
Copy link
Member

sapk commented Jan 15, 2020

Can you confirm that it was fixed by 6ac563a ?

@lunny lunny deleted the lunny/migrate_reactions branch January 15, 2020 11:20
This was referenced Jan 28, 2020
Open
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@sapk sapk sapk approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @6543 @codecov-io @sapk @guillep2k @GiteaBot