-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global variables for all query fields #12
Conversation
While we're at it, can we do this for all the query parameters? ( |
No problem, I'll add them later |
Should we add a FieldName field at the end of all fields to better express the function of the field? The current field name may be ambiguous, for example, |
I'm fine with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few recommendations for the documentation. Otherwise it looks good to me! Thank you very much! 👍🏻
Pull Request Test Coverage Report for Build 13654836363Details
💛 - Coveralls |
Co-authored-by: SystemGlitch <[email protected]>
Co-authored-by: SystemGlitch <[email protected]>
Co-authored-by: SystemGlitch <[email protected]>
Thank you! 🎉 |
As discussed in go-goyave/goyave#242,
QueryParamPage
andQueryParamPerPage
are added to change the current page number field name and the data size per page field name in pagination parameters.