Unresolved struct field inspection #2892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolotov
requested changes
May 24, 2017
| GoStructType structType = ObjectUtils.tryCast(startElement, GoStructType.class); | ||
| if (structType == null) return; | ||
| List<GoFieldDeclaration> declarations = structType.getFieldDeclarationList(); | ||
| PsiElement anchor = !declarations.isEmpty() ? ContainerUtil.getLastItem(declarations) : structType.getLbrace(); |
There was a problem hiding this comment.
= ContainerUtil.getLastItem(declarations, structType.getLbrace)
| if (structType == null) return; | ||
| List<GoFieldDeclaration> declarations = structType.getFieldDeclarationList(); | ||
| PsiElement anchor = !declarations.isEmpty() ? ContainerUtil.getLastItem(declarations) : structType.getLbrace(); | ||
| if (anchor != null) structType.addAfter(GoElementFactory.createFieldDeclaration(project, myFieldText, myTypeText), anchor); |
There was a problem hiding this comment.
When can it happen? Can you test this?
| GoType type = qualifier != null ? qualifier.getGoType(null) : null; | ||
| GoStructType structType = type != null ? ObjectUtils.tryCast(type.getUnderlyingType(), GoStructType.class) : null; | ||
| if (!"_".equals(reference.getCanonicalText()) && structType != null) { | ||
| fixes = new LocalQuickFix[]{new GoAddStructFieldFix(reference.getCanonicalText(), getTypeName(o), structType)}; |
There was a problem hiding this comment.
Usually, psi element that is passed to QuickFix is an inspection holder. In this case you pass there the element that should be changed, not the unresolved element. It's bad, because the struct type or unresolved reference could completely changed on the moment of quickfix invocation and should not be modified,
wbars
force-pushed
the
unresolved_struct_fields
branch
from
a2737bd
to
2558b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.