Fix DIGEST-MD5 auth #545
Merged
Fix DIGEST-MD5 auth #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The saslBindInProgress (14) description does not specify that the additional saslBindInProgress (14) should only be used in conjunction with qop=auth-int |
cpuschma
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thank you very much for your PR, @andy-igoshin ! May you please take a look at my comment?
cpuschma
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LDAP servers in the process of performing DIGEST-MD5 authentication respond with an additional saslBindInProgress (14) even if qop=auth is matched. Because of this, MD5Bind in go-ldap terminates unsuccessfully.
OpenLDAP ldapsearch and perl Net::LDAP handle this situation successfully.
This patch fixes this problem in go-ldap.