Update golang.org/x/net dependency #553
Open
+20
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vulnerability in golang.org/x/net prior to version 0.36.0 does not apply to this module, however for general hygiene we're updating the dependencies. This has pushed the issue of which versions of Go we support; the go.mod file from golang.org/x/net requires Go version 1.23 minimum, and given that the Go maintainers only support the last two versions, this change reduces the test matrix to the last two versions.
|
Also; I kicked off a poll/discussion around dropping support for old versions of Go: https://github.com/orgs/go-ldap/discussions/554 |
cpuschma
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vulnerability in golang.org/x/net prior to version 0.36.0 does not apply to this module, however for general hygiene we're updating the dependencies.
This has pushed the issue of which versions of Go we support; the go.mod file from golang.org/x/net requires Go version 1.23 minimum, and given that the Go maintainers only support the last two versions, this change reduces the test matrix to the last two versions.