fixes issue 375: context not preserved after routing #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After RouteInfo is called new request object with new context is passed, and all middlewares handling that request after returning don't have access to it. This fix copies the request with routing context to the request passed as a function variable so all middlewares now preserve the request context. Signed-off-by: Marko Juraga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After RouteInfo is called new request object with new context is passed, and all middlewares handling that request after returning don't have access to it. This fix copies the request with routing context to the request passed as a function variable so all middlewares now preserve the request context.
Change type
Please select: 🔧 Bug fix
Short description
Fixes
fixes #375