Refactor user file structure, add mocks and tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marrriamme
commented
Mar 6, 2025
marrriamme
commented
- Поменяла разположение файлов
- Добавила моки
- Добавила тесты
Benzogang-Tape
approved these changes
Mar 6, 2025
internal/transport/jwt/jwt.go
Outdated
| if err != nil { | ||
| log.Fatal("Error loading .env file") | ||
| } | ||
| secretKey := os.Getenv("TOKEN_SECRET") |
There was a problem hiding this comment.
Переименуй в JWT_SIGNATURE
internal/transport/jwt/jwt.go
Outdated
| func (t *Tokenator) ParseJWT(tokenString string) (*JWTClaims, error) { | ||
| err := godotenv.Load() | ||
| if err != nil { | ||
| log.Fatal("Error loading .env file") |
There was a problem hiding this comment.
Fatal насколько я помню делает под капотом os.Exit(1), тут лучше просто залогировать и вернуть ошибку. Если ещё где-то есть log.Fatal(), кроме main.go, то тоже поправь(к тестам не относится)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.