Repository navigation
Apply go fix - #2
Merged
Merged
Conversation
Result of `go fix ./...` under Go 1.26: the rules-to-string loop in TestParse now builds through strings.Builder instead of repeated string concatenation.
umputun
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fix ./...under Go 1.26 rewrites the rules-to-string loop inTestParseto build throughstrings.Builderinstead of repeated string concatenation. Test-only change, behaviour is identical andstrings.Builderis well within the Go 1.23 baseline ingo.mod.Worth noting that
.golangci.ymldeliberately excludes staticcheckQFquickfix suggestions and this is the same flavour of change, so if you would rather keep the plain concatenation, this one can be dropped.