fix: Fixed functions of decodeJson do not return. #1002
Conversation
jeevatkm
left a comment
jeevatkm
left a comment
There was a problem hiding this comment.
@Khachi-at Thanks for the PR. Please see my comment.
response.go
Outdated
| r.bodyBytes = append([]byte{}, b.Bytes()...) | ||
| closeq(r.Body) | ||
| r.Body = &nopReadCloser{r: bytes.NewReader(r.bodyBytes)} | ||
| r.Body = io.NopCloser(bytes.NewReader(r.bodyBytes)) |
There was a problem hiding this comment.
@Khachi-at nopReadCloser has a functionality. If any issues, we have to fix that instead of replacing it with io.NopCloser.
If you're interested in finding a fix, kindly update the PR. Otherwise, let me know. I will have a look at #1001.
There was a problem hiding this comment.
@jeevatkm Hello, the PR has been updated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #1002 +/- ##
==========================================
+ Coverage 99.82% 99.85% +0.03%
==========================================
Files 18 18
Lines 3896 3362 -534
==========================================
- Hits 3889 3357 -532
+ Misses 5 3 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Fixed the issuce