Pass task vars to deferred tasks. #2418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deferred task was recalculating vars which results in re-evaluation of templated and sh vars. This might not be desired in the case where values change with each evaluation; e.g. template function
randInt.This PR passes the task Vars to the deferred task, and removes the code which previously re-evaluated the vars. This works and I do not notice any point in the code where the task Vars would be mutilated (changed) so I did not use the DeepCopy() function of the Vars object when calling
runDeferred(). I think this will be OK, but I would still review that part again.fixes #2244