chore: pin golangci-lint tool version #2475
Conversation
There was a problem hiding this comment.
golangci-lint is a huge dependency. I wonder if it’s viable to extract tools into a separate Go module.
There was a problem hiding this comment.
Would need a wrapper script, at which point might be easier to use https://github.com/cashapp/hermit for bin/golangci-lint.
There was a problem hiding this comment.
How hard is it to just install version 2.1.0 of golangci-lint?
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.1.0
Having a task which does that, to setup a dev environment, might be nice. However, users of Task don't want to install all those modules.
There was a problem hiding this comment.
It's a huge pain to have to swap your version of golangci-lint for every go project you use.
Agree the mod changes are heavy.
3 participants
Pinned golangci-lint as a Go tool so my first contribution wouldn’t turn into a hunt for the "right" version instead of actual code, and in the process captured its whole dependency graph to keep lint runs hermetic and reproducible for everyone.
The exact commands are:
Because it causes so much churn to go.mod, I'd suggest a core contributor verify the changes!