[Improvement] Decompose proxy generator#393
Conversation
| BODY; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The closing brace for the class must go on the next line after the body
| string $joinPointType, | ||
| string $methodName, | ||
| array $advices | ||
| ): MethodInvocation { |
There was a problem hiding this comment.
There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found 0 spaces
…ild code generation
lisachenko
force-pushed
the
feature/decompose-proxy-generator
branch
from
5aad5c7 to
dd47ea6
Compare
|
The inspection completed: No new issues |
TheCelavi
left a comment
TheCelavi
left a comment
There was a problem hiding this comment.
Didn't went into every detail, but seams legit. I like zend-code, why not?
|
@TheCelavi Thanks for reviewing! But all @Ocramius's tools depend on |
That means that you are betting on Ocramius's good health and well being? He is old, and I heard that he drinks a lot... :D :D :D |
|
Don't forget that I'm also affected by chronic laziness! |
Ah, it's acceptable for me, we can proceed with that, because we are lazy too! ⬆️ 😄 🍻 |
5 participants
This PR adds one more dependency, but makes core more readable and maintainable. Hope, that
zendframework/zend-codeis good enough to be used as code generator.