fix VariationAttributes type location #39
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spiegel-im-spiegel , please review this tiny and straightforward PR when you have a chance |
Oakes6
reviewed
Aug 29, 2025
| } | ||
| Offers *struct { | ||
| VariationAttributes []VariationAttribute `json:",omitempty"` |
There was a problem hiding this comment.
It looks like the outer level member is VariationSummary.
Oakes6
reviewed
Aug 29, 2025
| @@ -182,9 +182,9 @@ type Item struct { | |||
| Currency string | |||
| } | |||
| } `json:",omitempty"` | |||
| VariationAttributes []VariationAttribute `json:",omitempty"` | |||
There was a problem hiding this comment.
This member needs to stay. Their schema doesn't include it, but glance at the sample responses in the documentation. It includes it there and I'm able to get information by testing locally as well.
There was a problem hiding this comment.
Yeah, VariationAttributes is under the VariationsResult.Items[i] and not under VariationsResult.Items[i].ItemInfo in the sample response
|
Disregard comments. This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey mate!
Thanks for sharing this SDK - it is very useful as I don't need to duplicate all the code for interacting with Amazon PA API in my project.
However, I've noted one issue that blocks me from getting VariationAttributes data
q := query.NewGetVariations( client.Marketplace(), client.PartnerTag(), client.PartnerType(), ).ASIN(productID). EnableImages(). EnableItemInfo(). EnableOffers(). EnableVariationSummary(). ParentASIN()I believe the issue is that the entity/entity.go type is not compatible with Amazon PA API response structure.
Current type VariationAttributes type location:
Item.ItemInfo.VariationAttributes
GetVariation operation VariationAttributes type location:
Item.VariationAttributes
Please, see:
https://webservices.amazon.com/paapi5/documentation/get-variations.html