Skip to content

stages/authenticator_webauthn: accept ML-DSA credentials - #26381

Merged
PeshekDotDev merged 3 commits into
mainfrom
stages/authenticator_webauthn-mldsa
Oct 16, 2026
Merged

PeshekDotDev merged 3 commits into
mainfrom
stages/authenticator_webauthn-mldsa

Conversation

@PeshekDotDev

Copy link
Copy Markdown
Contributor

Details

This PR allows for support of ML-DSA with WebAuthn

What does this PR change?

We override the default list of accepted algorithms and add ML-DSA to it. Since no authenticators currently support it, and some browsers may throw an error if given a suggestion for an unknown algorithm, we put it at the bottom of the list. This means only an authenticator that ONLY supports ML-DSA will currently use this feature.

Why is this change needed?

This helps us test for and prepare for when authenticators begin to use ML-DSA

How was this tested?

Unit tests and via the RS-Key project

Linked issues


Checklist

  • The project has been linted, built, and tested (make all)
  • The documentation has been updated and formatted (make docs)
  • I have read the AI usage policy.

@netlify

netlify Bot commented Sep 23, 2026

Copy link
Copy Markdown

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 9b75724
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6ab392ab4d72de0008a02621
😎 Deploy Preview https://deploy-preview-26381--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (1f37234) to head (5bde5cf).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26381      +/-   ##
==========================================
- Coverage   92.28%   92.25%   -0.04%     
==========================================
  Files        1183     1184       +1     
  Lines       79391    79476      +85     
  Branches     4351     4351              
==========================================
+ Hits        73263    73317      +54     
- Misses       6062     6093      +31     
  Partials       66       66              
Flag Coverage Δ
conformance 32.45% <2.32%> (-0.04%) ⬇️
e2e 37.16% <2.32%> (-0.05%) ⬇️
integration 28.81% <2.32%> (-0.53%) ⬇️
rust 44.42% <ø> (ø)
unit 93.94% <100.00%> (+<0.01%) ⬆️
unit-migrate 93.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Playwright e2e

Download this run's HTML report and traces, then open the report:

gh run download 38863164193 -D playwright-artifacts
npx playwright show-report playwright-artifacts/playwright-report

Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-5bde5cf658f7d5c4710537d95a940f24270b8be7
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-5bde5cf658f7d5c4710537d95a940f24270b8be7

Afterwards, run the upgrade commands from the latest release notes.

@PeshekDotDev
PeshekDotDev marked this pull request as ready for review October 8, 2026 08:00
@PeshekDotDev
PeshekDotDev requested review from a team as code owners October 8, 2026 08:00
@PeshekDotDev
PeshekDotDev requested a review from a team as a code owner October 16, 2026 06:46
@PeshekDotDev
PeshekDotDev merged commit 88984b4 into main Oct 16, 2026
148 checks passed
@PeshekDotDev
PeshekDotDev deleted the stages/authenticator_webauthn-mldsa branch October 16, 2026 08:22
@github-project-automation github-project-automation Bot moved this from In Progress to Done in authentik Core Oct 16, 2026
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2026
* main: (101 commits)
  ci: exclude node_modules from Go lint (#26961)
  website/integrations: ch-ui: document the email_verified requirement (#26978)
  website/docs: add expression policy for case-insensitive unique usernames (#26974)
  core: prefetch token owners and memberships (#25803)
  website/integrations: add detailed explanation for setting GH Org limit (#8604)
  website/integrations: add opensearch (#26938)
  endpoints: fix MultipleObjectsReturned (#26971)
  core, web: update translations (#26963)
  website/docs: single-logout: add information around proxy providers for single logout (#26563)
  common/saml: move exceptions and logout request parser to common (#26533)
  stages/authenticator_webauthn: accept ML-DSA credentials (#26381)
  crypto: add ML-DSA certificate generation (#26380)
  website/integrations: add ch-ui (#26935)
  website/integrations: add kibana (#26936)
  core: bump pydantic from 2.13.5 to 2.14.0 (#26969)
  core: bump rust-toolchain from 1.99.0 to 1.99.1 (#26967)
  core: bump aws-cdk-lib from 2.272.0 to 2.273.0 (#26968)
  core: bump github.com/prometheus/client_golang from 1.24.1 to 1.25.0 (#26965)
  core: bump github.com/getsentry/sentry-go from 0.49.0 to 0.50.0 (#26966)
  web/admin: version banner (#26948)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants