Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outlined scenario results merged #10

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

lentil1016
Copy link
Contributor

@lentil1016 lentil1016 commented Oct 21, 2024

issue

When use scenario outline, the multiple results generated by examples will be displayed as one, for they have the same HistoryID
image
image

fix

this fix appends UUID to HistoryID to distinguish them apart.
image

@lentil1016
Copy link
Contributor Author

@vearutop Hi, this pr may need your attention, please. I'm not able to see the approval workflows.

@lentil1016
Copy link
Contributor Author

@vearutop It would be helpful to get some feedback, anytime.

@vearutop
Copy link
Member

Hi, thank you for raising this PR! Could you please add a relevant feature file to _testdata so that it is easier to check the effect of this change?

@lentil1016 lentil1016 force-pushed the fix/outline-results branch 2 times, most recently from d5f55be to 9a71f5f Compare October 28, 2024 21:34
@lentil1016
Copy link
Contributor Author

@vearutop Hi, thanks for feedback. I've added a testcase for this change and left a comment to show how this change affects the report rendering.

@vearutop vearutop merged commit 4d19402 into godogx:master Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants