Propagate panics in object constructors to Gd::from_init_fn(), new_gd(), new_alloc()
#1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
force-pushed
the
bugfix/init-unhandled-panic
branch
from
a4e4446 to
e9d517b
Compare
|
Might need some more testing in the editor, to see whether panics are actually printed (even when used from GDScript). |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #919.
User-facing APIs to construct
Gdobjects -- either via default constructor or viaGd::from_init_fn()-- now propagate any panics occurring ininit()or the passedinit_fn1:1 to the caller.In GDScript, constructing a Rust instance whose constructor panics will yield
null.