Skip to content

Cherry-picks for the godot-cpp 4.3 branch - 5th batch #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: 4.3
Choose a base branch
from

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 24, 2025

The 5th (and possibly last) batch of PR's marked with cherrypick:4.3

dsnopek and others added 10 commits June 24, 2025 12:42
This is required when publishing to the App Store, and consistent with
what we already do for the macOS deployment target.

(cherry picked from commit 4879eb7)
(cherry picked from commit ca5af3c)
@dsnopek dsnopek force-pushed the 4.3-cherrypicks-5 branch from f026fc9 to 53caa6a Compare June 24, 2025 19:50
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 24, 2025

I've snuck a unique, non-cherrypicked commit into this PR:

53caa6a

It updates to use ubuntu-22.04 on CI, which was done for 4.4 and master in PR #1574, but nothing else in that PR can be cherrypicked, which is why I made the unique commit

NOTE: The CI is still failing, but that because of a windows-2019 brownout that GitHub is doing. I've just posted PR #1804 to take care of that update, which we can add in here once it's merged into master

@dsnopek dsnopek force-pushed the 4.3-cherrypicks-5 branch from 68dd1fa to 70c5f71 Compare June 25, 2025 13:55
(cherry picked from commit 8938e7e)
@dsnopek dsnopek force-pushed the 4.3-cherrypicks-5 branch from 70c5f71 to b1e2ac5 Compare June 25, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants