Add smoke test with Tween to check for issues with handling RefCounted
#1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
enhancement
Bromeon
reviewed
Oct 28, 2025
dsnopek
force-pushed
the
tween-smoke-test
branch
from
3955273 to
618ee44
Compare
Ivorforce
approved these changes
Oct 28, 2025
|
|
||
| bool Example::test_tween_smoke_test() { | ||
| Ref<Tween> tween = create_tween(); | ||
| return tween.is_valid() && tween->is_class("Tween") && tween->get_reference_count() > 1; |
There was a problem hiding this comment.
I assume > 1 means "1 reference by this function, one by the tween owner"?
There was a problem hiding this comment.
Yes. In current Godot the reference count is 2, one for this function and the other is SceneTree::tweens
Bromeon
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweens are an interesting case, becauseNode::create_tween()will return the newTween, but also adds it to an internal list that will lead to it being processed later and eventually cleaned up.If we have an issue with handling
RefCounted, we may miss it on a simple function that just returns aRefCounted, but doesn't maintain another reference.Node::create_tween()is also a fairly common method, so this is a good smoke test to have!(Note: This test would have helped with godotengine/godot#86079)