Fix uniform sets in "Compute Texture" #1247
Merged
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Sep 13, 2025
This was referenced Sep 14, 2025
beicause
reviewed
Sep 15, 2025
| @@ -143,13 +143,13 @@ var pipeline: RID | |||
| var texture_rds: Array[RID] = [RID(), RID(), RID()] | |||
| var texture_sets: Array[RID] = [RID(), RID(), RID()] | |||
|
|
|||
| func _create_uniform_set(texture_rd: RID) -> RID: | |||
| func _create_uniform_set(texture_rd: RID, uniform_set: int) -> RID: | |||
| var uniform := RDUniform.new() | |||
| uniform.uniform_type = RenderingDevice.UNIFORM_TYPE_IMAGE | |||
| uniform.binding = 0 | |||
| uniform.add_id(texture_rd) | |||
| # Even though we're using 3 sets, they are identical, so we're kinda cheating. | |||
| # Create our uniform sets so we can use these textures in our shader. | ||
| var current_set := _create_uniform_set(current_texture_rd, 0) | ||
| var previous_set := _create_uniform_set(previous_texture_rd, 1) | ||
| var next_set := _create_uniform_set(next_texture_rd, 2) |
There was a problem hiding this comment.
This seems to create uniforms every frame, no? I think we just need 9 uniforms and should cache them. Or use UniformSetCacheRD
There was a problem hiding this comment.
Feel free to open a PR for this 🙂
Same for the above comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uniform sets that were hardcoded as
0, which seems to work withv4.4but has broken this demo inv4.5.Still works with
v4.4.1✅Also removed the unnecessary texture usage bits.