-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Show handedness in Vector2's angle-related images #11428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Show handedness in Vector2's angle-related images #11428
Conversation
66d6b04 to
f3219a2
Compare
|
Seems there was a CI issue that got fixed in master, so I rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and thanks for the rebase! Would you mind taking the chance to convert these images to WebP? We're in the process of moving images over to WebP whenever we update existing ones, see image contribution guidelines for details.
247acb2 to
0a58f5a
Compare
|
@BlueberryGecko Much appreciated! Note that the |
0a58f5a to
dbc758d
Compare
Ah, that should have been somewhat obvious... I opened the PR (godotengine/godot#112341). I assume the PRs have to be merged somewhat in sync? Let me know if there's anything more I need to do for that. (I removed the changes to the .rst here and amended the commit. I hope that's correct now.) |
|
You appear to have used lossy WebP, which means it looks worse for this kind of drawing:
It's also prone to generation loss if further edits are performed. You should use lossless WebP for small images (<= 300 KB). |
dbc758d to
9bdaf24
Compare
9bdaf24 to
ea4652c
Compare
|
(I don't think it's correct yet, the colors still don't quite match (I also messed up an arrow during an undo). Something due to the color profiles. Will look at it later) |


Imo the handedness of angles in the documentation images for methods such as Vector2.angle_to should be explicitly shown.
My hope is that this adds visual clarification/intuition that:
a.angle_to(b) != b.angle_to(a))