Use new dock system for SpriteFrames Dock #113275
Open
+27
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you have stack trace for the crash? EDIT: |
17 tasks
KoBeWi
reviewed
Nov 28, 2025
Comment on lines
+616
to
+618
| if (!dock->transient) { | ||
| floating_docks_dump[name] = window_dump; | ||
| } |
Member
There was a problem hiding this comment.
Instead of preventing the window from being saved, we could instead prevent loading it. It can help fix #113259 If you make a dock floating, it should stay floating.
Member
There was a problem hiding this comment.
This still needs to be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #113024
This PR updates the SpriteFrames docks to use the new dock system. The layout is very horizontal but with some changes, it seems possible to make it vertical. That can be done in a follow-up PR.
This PR also contains a fix for transient docks, where it would be opened if the layout was saved while it was floating, leading to crash cases where the dock knew it wasn't editing anything, but it was able to be opened by loading the layout, so it was unsafely accessing the nullptr.