Fix dock opening focus #113296
Open
Fix dock opening focus #113296
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
reviewed
Nov 28, 2025
KoBeWi
force-pushed
the
soft_open_gently
branch
from
270b14d to
cea95e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorDock have
open()andmake_visible()methods, which are very similar. The main difference is thatopen()does nothing if the dock is already opened. If it's closed, the method will open it and make focused (i.e. switch to tab, open bottom panel etc.).This PR changes
open()to not focus the dock. There ismake_visible()for that.Also changed some
open()calls tomake_visible(), to fix some docks not being properly focused when they should.