-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mqtt default subscription #1510
Conversation
…default_subscription
This looks unnecessary to be exposed. Subscribe can internally decide this. @Umang01-hash |
Sure @vikash will do it internally. |
…default_subscription
…ction before Subscription
…ofr into fix/mqtt_default_subscription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are internally checking whether the client is connected or not...the IsConnected()
function should be unexported.
Sure done. |
Pull Request Template
Description:
IsConnected()
method to all pub-sub clients so that during subscription we can have a check of it before actually trying to subscribe.Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!