En/graceful shutdown config #1529
Open
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ul_shutdown_config
aryanmehrotra
requested changes
Feb 28, 2025
| // Goroutine to handle shutdown when context is canceled | ||
| go func() { | ||
| <-ctx.Done() | ||
|
|
||
| // Create a shutdown context with a timeout | ||
| shutdownCtx, done := context.WithTimeout(context.WithoutCancel(ctx), shutDownTimeout) | ||
| shutdownCtx, done := context.WithTimeout(context.Background(), timeout) |
There was a problem hiding this comment.
why did we change the context?
There was a problem hiding this comment.
In the original code, context.WithoutCancel was used to ensure the shutdown process had a fixed timeout (shutDownTimeout) to complete before termination.
In the updated code, the getShutdownTimeoutFromConfig function fetches the shutdown timeout from the configuration, allowing it to be configurable.
If context.WithCancel were used instead, the shutdown context would be canceled when the parent context is canceled, potentially cutting short the shutdown process and not respecting the full timeout value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description:
SERVER_SHUTDOWN_THRESHOLDto change the default graceful shutdown timeout from 30sec.Checklist:
goimportandgolangci-lint.Thank you for your contribution!