Rearranging Middlewares to allow Authentication before setting WebSocket Conn #1530
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coolwednesday
commented
Feb 26, 2025
•
coolwednesday
commented
- Closes Cannot Close websocket conneciton in case of unauthorised request #1526
- As websocket connection does not inherently provide authentication support. It is favourable to authenticate before starting a websocket connection. This can only be done, if user's added authentication or other middlewares are executed before, upgrading to a websocket connection. This PR addresses the same.
coolwednesday
changed the title
Umang01-hash
requested changes
Feb 28, 2025
Umang01-hash
approved these changes
Feb 28, 2025
aryanmehrotra
requested changes
Feb 28, 2025
Comment on lines
+31
to
+34
| a.httpServer.router.Use(middleware.WSHandlerUpgrade(a.container, a.httpServer.ws)) | ||
| a.httpServer.router.Use(middleware.Logging(a.Logger())) | ||
| a.httpServer.router.Use(middleware.Metrics(a.Metrics())) | ||
| } |
There was a problem hiding this comment.
When other default middleware's are being registered in httpServer, we should not be registering any default middleware here.
There was a problem hiding this comment.
I have added a developer note ... explaining the necessity to register it here ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.