Fixes #49 fix console error by letting event bubble to helper function#50
Fixes #49 fix console error by letting event bubble to helper function#50quangta93 wants to merge 3 commits intogogoair:masterfrom
Conversation
|
Thanks for the PR @quangta93. Good catch, but the solution doesn't eliminate the core of the issue, so it fixes the problem with clicking on the dropdown icon but possibly breaks another use case: custom handling of dropdown item click. The reason why it works is removing the I think a simple solution here would be to add a guard to const onClick = e => {
if (!handleClick) return;
e.stopPropagation();
return handleClick();
};Feel free to prove me wrong if that's the case. It's been a while since I've used or looked at this code. |
|
@MilosRasic I believe my changes don't break custom handling of dropdown item click. What I did was lifting the handling of click events from In addition, all SVG icons are now using |
No description provided.