add projectID flag option to delete project command #324
Conversation
Signed-off-by: adityachopra29 <[email protected]>
|
@bupd I have made the changes. Plz have a look if anything needs to be changed.
|
| @@ -45,6 +46,7 @@ func DeleteProjectCommand() *cobra.Command { | |||
|
|
|||
| flags := cmd.Flags() | |||
| flags.BoolVar(&forceDelete, "force", false, "Deletes all repositories and artifacts within the project") | |||
| flags.BoolVar(&useProjectID, "projectID", false, "If set, treats the provided argument as a project ID instead of a project name") | |||
There was a problem hiding this comment.
I would suggest project ID to be a flag to which you can pass project ids. rather than having it as a boolean. since this would allow the args to always be projectname maintaining consistency.
Thanks
There was a problem hiding this comment.
I would suggest project ID to be a flag to which you can pass project ids. rather than having it as a boolean. since this would allow the args to always be projectname maintaining consistency.
@bupd
So are you suggesting to make projectName an optional input for the delete command? Because I was under the understanding that we are giving projectID when we did not know the projectName.
Right now, when we don't give projectName, we enter the prompt mode and again choose projectName. So do we want to change that behavior when the projectID flag is given?
| @@ -32,16 +32,16 @@ func ViewCommand() *cobra.Command { | |||
| Args: cobra.MaximumNArgs(1), | |||
| Run: func(cmd *cobra.Command, args []string) { | |||
| var err error | |||
| var projectName string | |||
| var projectNameOrID string | |||
There was a problem hiding this comment.
have it just projectName and have different var for projectID.
|
|
||
| func CreateBoolPointer(b bool) *bool { | ||
| return &b | ||
| } | ||
|
|
| ctx, client, err := utils.ContextWithClient() | ||
| if err != nil { | ||
| return repository.ListRepositoriesOK{}, err | ||
| } | ||
| projectName := projectNameOrID |
Which problem is this PR solving?
Description of the changes
projectIDflag todeletecommand inprojectcommand.projectIDparameter to all corresponding functionsHow was this change tested?