add possibility to ovveride jobservice strategyType. Signed-off-by: G…

…umar Minibaev <[email protected]>
goharbor · Feb 11, 2025 · 280ae25 · 280ae25
1 parent 6c342ac
commit 280ae25
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -248,6 +248,7 @@ The following table lists the configurable parameters of the Harbor chart and th
 | `jobservice.image.tag`                                                | Tag for jobservice image                                                                                                                                                                                                                                                                                                                                                                                                                                         | `dev`                                 |
 | `jobservice.replicas`                                                 | The replica count                                                                                                                                                                                                                                                                                                                                                                                                                                                | `1`                                   |
 | `jobservice.revisionHistoryLimit`                                     | The revision history limit                                                                                                                                                                                                                                                                                                                                                                                                                                       | `10`                                  |
+| `jobservice.updateStrategy.type`                                      | The update strategy for jobservice deployment (if needs to be different from others): `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported                                                                                            | same as general `updateStrategy.type`|
 | `jobservice.maxJobWorkers`                                            | The max job workers                                                                                                                                                                                                                                                                                                                                                                                                                                              | `10`                                  |
 | `jobservice.jobLoggers`                                               | The loggers for jobs: `file`, `database` or `stdout`                                                                                                                                                                                                                                                                                                                                                                                                             | `[file]`                                |
 | `jobservice.loggerSweeperDuration`                                    | The jobLogger sweeper duration in days (ignored if `jobLoggers` is set to `stdout`)                                                                                                                                                                                                                                                                                                                                                                              | `14`                                  |

diff --git a/templates/jobservice/jobservice-dpl.yaml b/templates/jobservice/jobservice-dpl.yaml
@@ -11,8 +11,9 @@ spec:
   replicas: {{ .Values.jobservice.replicas }}
   revisionHistoryLimit: {{ .Values.jobservice.revisionHistoryLimit }}
   strategy:
-    type: {{ .Values.updateStrategy.type }}
-    {{- if eq .Values.updateStrategy.type "Recreate" }}
+    {{- $strategyType := (.Values.jobservice.strategyType | default .Values.updateStrategy.type) }}
+    type: {{ $strategyType }}
+    {{- if eq $strategyType "Recreate" }}
     rollingUpdate: null
     {{- end }}
   selector:

diff --git a/values.yaml b/values.yaml
@@ -649,6 +649,9 @@ jobservice:
   # mount the service account token
   automountServiceAccountToken: false
   replicas: 1
+  # uncomment following lines to specify different updateStrategy for jobService
+  # updateStrategy:
+  #   type: ReCreate
   revisionHistoryLimit: 10
   # resources:
   #   requests: