Fix the nginx's containerPort (#1497)

It is better to limit the nginx's containerPort and port to only those that are enabled. 8443 is valid only if .Values.expose.tls.enabled is true. 4443 is no longer used since notary was removed. Signed-off-by: Mitsuru Kariya <[email protected]>
goharbor · Feb 14, 2024 · 53ce4a2 · 53ce4a2
1 parent 863d4d0
commit 53ce4a2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/templates/nginx/deployment.yaml b/templates/nginx/deployment.yaml
@@ -89,8 +89,9 @@ spec:
 {{- end }}
         ports:
         - containerPort: 8080
+        {{- if .Values.expose.tls.enabled }}
         - containerPort: 8443
-        - containerPort: 4443
+        {{- end }}
         volumeMounts:
         - name: config
           mountPath: /etc/nginx/nginx.conf