Template External Url

[neevnuv]

Description

This PR introduces templating support for the externalURL value inside the core-cm ConfigMap by wrapping it with tpl, allowing for dynamic evaluation of Helm templates.

Changes

Updated core-cm to use {{ tpl .Values.externalURL . }} instead of a static value.

Rationale

Enables users to reference other values or use Helm functions within externalURL.
Increases flexibility for dynamic configurations in different environments.

[neevnuv]

Hi @MinerYang, I would love if you could give this PR a view 😁.

[MinerYang]

Hi @neevnuv ,

Thanks for contribution to harbor-helm.

By getting some contexts of using tpl functions for helm template, the only "potential benefit" I could thought would be dynamically rendering the templating at the the runtime. However when you doing this, other configs like certificate for nginx tls config would be inconsistent and causing issues. And using the chain templates function would increasing our helm template complexity, from my perspective, a static rendering is enough for this value.

However, I will keep this PR open and let's see if we will have same requirements from the community in the future. In the meantime, you could use this at your own fork repository.

Best,
Miner