Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix full_stack.yaml #299

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

bitsf
Copy link
Collaborator

@bitsf bitsf commented Dec 8, 2020

close goharbor/harbor-cluster-operator#235
some setting is not correct in sample full_stack.yaml

Signed-off-by: Ziming Zhang <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Ghostbaby Ghostbaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ghostbaby Ghostbaby merged commit cfd8b08 into goharbor:develop Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants