Skip to content

Rebuild goharbor/photon image before create new harbor base images#23248

Merged
wy65701436 merged 5 commits into
goharbor:mainfrom
jUDASmILE:26may18_modify_photonbase_build
May 18, 2026
Merged

Rebuild goharbor/photon image before create new harbor base images#23248
wy65701436 merged 5 commits into
goharbor:mainfrom
jUDASmILE:26may18_modify_photonbase_build

Conversation

@jUDASmILE
Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Motivation:
Currently, the goharbor/photon:5.0 image relies on a fixed snapshot from the photon 91 branch. Keeping this updated requires manual intervention—such as modifying the Dockerfile or running scheduled refreshes—which adds unnecessary maintenance overhead.

What this PR does:
This PR updates the build process to leverage the Photon team's new branching strategy by using the photon-snapshot repository as the source.

Impact:
Whenever we create new Harbor base images, the build will automatically pull the latest upstream changes (whether the Photon team releases a new snapshot or cuts a new branch). This eliminates the need for manual updates and ensures our base images are consistently up-to-date.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

jUDASmILE added 2 commits May 18, 2026 11:37
Signed-off-by: jUDASmILE <judasmile@gmail.com>
Signed-off-by: jUDASmILE <judasmile@gmail.com>
@jUDASmILE jUDASmILE requested a review from a team as a code owner May 18, 2026 05:57
@wy65701436 wy65701436 added the release-note/update Update or Fix label May 18, 2026
Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.03%. Comparing base (889364f) to head (06a0c9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #23248      +/-   ##
==========================================
- Coverage   66.03%   66.03%   -0.01%     
==========================================
  Files        1074     1074              
  Lines      116854   116854              
  Branches     2955     2955              
==========================================
- Hits        77168    77160       -8     
- Misses      35402    35409       +7     
- Partials     4284     4285       +1     
Flag Coverage Δ
unittests 66.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 merged commit 33b363c into goharbor:main May 18, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants