Fix ios mobile menu scroll #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this theme as a live tutorial of the latest Hugo features. It is awesome.
Currently the mobile menu does not scroll on some older ios devices such as iPhone 6 running IOS 11.4. It is extremely difficult or not even possible to access some menu items on small screens using mobile Safari. This causes usability issues. There are also challenges to access the docs menu items using Chrome on iPhone 6. The issues may also exist on newer models.
This PR introduces a tiny (about 1kb) js library to disable body scrolling when the mobile menu is open, so that only the mobile menu can scroll. Some minor changes are required on partials/nav-mobile.html to enable menu scrolling.
I have tested on iPhone 6 using Safari and Chrome, and the mobile menu scrolled quite well, both in portrait view and landscape view. It should work on even older devices.
Please review and consider the changes.