net/url: return an error if port is out of range #69444

dunglas · 2024-09-13T09:50:41Z

The existing implementation does not validate
that the port number is in the allowed range.

WHATWG URL Living Standard mandates that
parsing URLs with invalid ports fails:
https://url.spec.whatwg.org/#port-out-of-range

Fixes #69443.

The existing implementation does not validate that the port number is in the allowed range. WHATWG URL Living Standard mandates that parsing URLs with invalid ports fails: https://url.spec.whatwg.org/#port-out-of-range Fixes golang#69443.

gopherbot · 2024-09-13T09:57:10Z

This PR (HEAD: f8180b9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/613035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-14T02:12:27Z

Message from Cassondra Foesch:

Patch Set 1:

(2 comments)