-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: improve issue62407_test #70938
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 44be2a6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638036. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Cuong Manh Le: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Xu Liu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Xu Liu: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 2: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-04T15:34:26Z","revision":"208d5ff11d68d036824ed81cfac32e354b6ac321"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Failed Tryjobs:
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 3: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-04T15:47:28Z","revision":"bcdf61d11d7344d40a2e678cb6ca1c8e83affed3"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 3: Auto-Submit+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Keith Randall: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638036. |
The original issue62407_test also passes with versions prior to 1.23. The improvement makes it fail with versions prior to 1.23. Change-Id: I94bfb9d1ac695c8e07997d7029fc2101535e14f8 GitHub-Last-Rev: 44be2a6 GitHub-Pull-Request: #70938 Reviewed-on: https://go-review.googlesource.com/c/go/+/638036 Reviewed-by: Junyang Shao <[email protected]> Reviewed-by: Cuong Manh Le <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]>
This PR is being closed because golang.org/cl/638036 has been merged. |
The original issue62407_test also passes with versions prior to 1.23.
The improvement makes it fail with versions prior to 1.23.